netdev - Re: [PATCH net-next] net: sched: implement action-specific terse dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96c51cbb-1a72-d89d-5746-2930786f8afb@mojatatu.com>
Date:   Mon, 2 Nov 2020 07:26:05 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Vlad Buslov <vlad@...lov.dev>, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org
Cc:     xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next] net: sched: implement action-specific terse dump

Thanks Vlad. Ive run the basic test and it looks good.
One thing i discovered while testing is that if the
cookie is set, we also want it in the dump. Your earlier
comment that it only costs if it was set is on point.

So please remove that check below:

 > +	if (cookie && !from_act) {
 > +		if (nla_put(skb, TCA_ACT_COOKIE, cookie->len, cookie->data)) {
 > +			rcu_read_unlock();
 > +			goto nla_put_failure;
 > +		}

cheers,
jamal