netdev - Re: [PATCH net-next] net: sched: implement action-specific terse dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zh3z5y25.fsf@buslov.dev>
Date:   Mon, 02 Nov 2020 22:00:18 +0200
From:   Vlad Buslov <vlad@...lov.dev>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next] net: sched: implement action-specific terse dump

On Mon 02 Nov 2020 at 14:26, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> Thanks Vlad. Ive run the basic test and it looks good.
> One thing i discovered while testing is that if the
> cookie is set, we also want it in the dump. Your earlier
> comment that it only costs if it was set is on point.
>
> So please remove that check below:

Okay. Will send V2 shortly.

>
>
>> +	if (cookie && !from_act) {
>> +		if (nla_put(skb, TCA_ACT_COOKIE, cookie->len, cookie->data)) {
>> +			rcu_read_unlock();
>> +			goto nla_put_failure;
>> +		}
>
>
> cheers,
> jamal