netdev - Re: [PATCH v3 net-next 10/12] net: dsa: tag_dsa: let DSA core deal with TX reallocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <780eb021-17af-130d-5d49-56ab3eac7d7b@gmail.com>
Date:   Mon, 2 Nov 2020 12:52:09 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com, kuba@...nel.org,
        Christian Eggers <ceggers@...i.de>,
        Kurt Kanzenbach <kurt@...utronix.de>
Subject: Re: [PATCH v3 net-next 10/12] net: dsa: tag_dsa: let DSA core deal
 with TX reallocation



On 11/1/2020 11:16 AM, Vladimir Oltean wrote:
> Now that we have a central TX reallocation procedure that accounts for
> the tagger's needed headroom in a generic way, we can remove the
> skb_cow_head call.
> 
> Similar to the EtherType DSA tagger, the old Marvell tagger can
> transform an 802.1Q header if present into a DSA tag, so there is no
> headroom required in that case. But we are ensuring that it exists,
> regardless (practically speaking, the headroom must be 4 bytes larger
> than it needs to be).
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian