netdev - Re: [PATCH v3 net-next 11/12] net: dsa: tag_gswip: let DSA core deal with TX reallocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fe096a9-6d30-5e54-39b5-b371ed00d1f7@gmail.com>
Date:   Mon, 2 Nov 2020 12:52:27 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com, kuba@...nel.org,
        Christian Eggers <ceggers@...i.de>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Hauke Mehrtens <hauke@...ke-m.de>
Subject: Re: [PATCH v3 net-next 11/12] net: dsa: tag_gswip: let DSA core deal
 with TX reallocation



On 11/1/2020 11:16 AM, Vladimir Oltean wrote:
> Now that we have a central TX reallocation procedure that accounts for
> the tagger's needed headroom in a generic way, we can remove the
> skb_cow_head call.
> 
> This one is interesting, the DSA tag is 8 bytes on RX and 4 bytes on TX.
> Because DSA is unaware of asymmetrical tag lengths, the overhead/needed
> headroom is declared as 8 bytes and therefore 4 bytes larger than it
> needs to be. If this becomes a problem, and the GSWIP driver can't be
> converted to a uniform header length, we might need to make DSA aware of
> separate RX/TX overhead values.
> 
> Cc: Hauke Mehrtens <hauke@...ke-m.de>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian