netdev - Re: [net-next 14/15] ice: join format strings to same line as ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be6ac7df8079164d8e9cb42e381799629a4479fb.camel@kernel.org>
Date:   Mon, 02 Nov 2020 15:07:32 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org,
        sassmann@...hat.com, Aaron Brown <aaron.f.brown@...el.com>
Subject: Re: [net-next 14/15] ice: join format strings to same line as
 ice_debug

On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote:
> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> When printing messages with ice_debug, align the printed string to
> the
> origin line of the message in order to ease debugging and tracking
> messages back to their source.
> 

Just out of curiosity, you are only re-aligning the code and not the
printed messages themselves. How would this help ? did you mean help
with tracking the sources when doing grep like operations on the source
code ?