netdev - Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edf565cf-f75e-87a1-157b-39af6ea84f76@iogearbox.net>
Date:   Tue, 3 Nov 2020 09:46:29 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        David Ahern <dsahern@...il.com>
Cc:     Hangbin Liu <haliu@...hat.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        David Miller <davem@...emloft.net>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Jiri Benc <jbenc@...hat.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

On 11/3/20 7:58 AM, Andrii Nakryiko wrote:
> On Mon, Nov 2, 2020 at 7:47 AM David Ahern <dsahern@...il.com> wrote:
>> On 10/29/20 9:11 AM, Hangbin Liu wrote:
>>> This series converts iproute2 to use libbpf for loading and attaching
>>> BPF programs when it is available. This means that iproute2 will
>>> correctly process BTF information and support the new-style BTF-defined
>>> maps, while keeping compatibility with the old internal map definition
>>> syntax.
>>>
>>> This is achieved by checking for libbpf at './configure' time, and using
>>> it if available. By default the system libbpf will be used, but static
>>> linking against a custom libbpf version can be achieved by passing
>>> LIBBPF_DIR to configure. FORCE_LIBBPF can be set to force configure to
>>> abort if no suitable libbpf is found (useful for automatic packaging
>>> that wants to enforce the dependency).
>>>
>>> The old iproute2 bpf code is kept and will be used if no suitable libbpf
>>> is available. When using libbpf, wrapper code ensures that iproute2 will
>>> still understand the old map definition format, including populating
>>> map-in-map and tail call maps before load.
>>>
>>> The examples in bpf/examples are kept, and a separate set of examples
>>> are added with BTF-based map definitions for those examples where this
>>> is possible (libbpf doesn't currently support declaratively populating
>>> tail call maps).
>>>
>>> At last, Thanks a lot for Toke's help on this patch set.
>>
>> In regards to comments from v2 of the series:
>>
>> iproute2 is a stable, production package that requires minimal support
>> from external libraries. The external packages it does require are also
>> stable with few to no relevant changes.
>>
>> bpf and libbpf on the other hand are under active development and
>> rapidly changing month over month. The git submodule approach has its
>> conveniences for rapid development but is inappropriate for a package
>> like iproute2 and will not be considered.

I thought last time this discussion came up there was consensus that the
submodule could be an explicit opt in for the configure script at least?