netdev - Re: [PATCH stable] net: sch_generic: fix the missing new qdisc assignment bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201103110614.49116c3c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 3 Nov 2020 11:06:14 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     <gregkh@...uxfoundation.org>, <stable@...r.kernel.org>,
        <vpai@...mai.com>, <Joakim.Tjernlund@...inera.com>,
        <xiyou.wangcong@...il.com>, <johunt@...mai.com>,
        <jhs@...atatu.com>, <jiri@...nulli.us>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <john.fastabend@...il.com>,
        <eric.dumazet@...il.com>, <dsahern@...il.com>
Subject: Re: [PATCH stable] net: sch_generic: fix the missing new qdisc
 assignment bug

On Tue, 3 Nov 2020 11:25:38 +0800 Yunsheng Lin wrote:
> commit 2fb541c862c9 ("net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc")
> 
> When the above upstream commit is backported to stable kernel,
> one assignment is missing, which causes two problems reported
> by Joakim and Vishwanath, see [1] and [2].
> 
> So add the assignment back to fix it.
> 
> 1. https://www.spinics.net/lists/netdev/msg693916.html
> 2. https://www.spinics.net/lists/netdev/msg695131.html
> 
> Fixes: 749cc0b0c7f3 ("net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc")
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>

Acked-by: Jakub Kicinski <kuba@...nel.org>