netdev - Re: [bpf-next PATCH v2 1/5] selftests/bpf: Move test_tcppbf_user into test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgT0UeCcJc-N9UBHP7bwSB4Ca8G9b2Gt14z=nMkduTYHPaGyg@mail.gmail.com>
Date:   Tue, 3 Nov 2020 11:06:41 -0800
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>,
        john fastabend <john.fastabend@...il.com>,
        Kernel Team <kernel-team@...com>,
        Networking <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Lawrence Brakmo <brakmo@...com>, alexanderduyck@...com
Subject: Re: [bpf-next PATCH v2 1/5] selftests/bpf: Move test_tcppbf_user into test_progs

On Tue, Nov 3, 2020 at 10:34 AM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Sat, Oct 31, 2020 at 11:52 AM Alexander Duyck
> <alexander.duyck@...il.com> wrote:
> >
> > From: Alexander Duyck <alexanderduyck@...com>
> >
> > Recently a bug was missed due to the fact that test_tcpbpf_user is not a
> > part of test_progs. In order to prevent similar issues in the future move
> > the test functionality into test_progs. By doing this we can make certain
> > that it is a part of standard testing and will not be overlooked.
> >
> > As a part of moving the functionality into test_progs it is necessary to
> > integrate with the test_progs framework and to drop any redundant code.
> > This patch:
> > 1. Cleans up the include headers
> > 2. Dropped a duplicate definition of bpf_find_map
> > 3. Switched over to using test_progs specific cgroup functions
> > 4. Replaced printf calls with fprintf to stderr
>
> This is not necessary. test_progs intercept both stdout and stderr, so
> you could have kept the code as is and minimize this diff further. But
> it also doesn't matter all that much, so:

Yeah. I can probably just drop those changes if that is preferred. As
is all the printf/fprintf calls are eliminated by the end anyway.

> Acked-by: Andrii Nakryiko <andrii@...nel.org>

Thanks for the review.

- Alex