netdev - Re: [PATCH net-next] vxlan: Use a per-namespace nexthop listener instead of a global one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca51f883-736e-f862-a3b2-5f6f34b99d4d@gmail.com>
Date:   Mon, 2 Nov 2020 18:45:10 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, roopa@...dia.com,
        mlxsw@...dia.com, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next] vxlan: Use a per-namespace nexthop listener
 instead of a global one

On 11/1/20 4:39 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> The nexthop notification chain is a per-namespace chain and not a global
> one like the netdev notification chain.
> 
> Therefore, a single (global) listener cannot be registered to all these
> chains simultaneously as it will result in list corruptions whenever
> listeners are registered / unregistered.
> 
> Instead, register a different listener in each namespace.
> 
> Currently this is not an issue because only the VXLAN driver registers a
> listener to this chain, but this is going to change with netdevsim and
> mlxsw also registering their own listeners.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  drivers/net/vxlan.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>