netdev - Re: [PATCH net-next] vxlan: Use a per-namespace nexthop listener instead of a global one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201103152435.71fe4b0b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 3 Nov 2020 15:24:35 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org,
        davem@...emloft.net, roopa@...dia.com, mlxsw@...dia.com,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next] vxlan: Use a per-namespace nexthop listener
 instead of a global one

On Mon, 2 Nov 2020 18:45:10 -0700 David Ahern wrote:
> On 11/1/20 4:39 AM, Ido Schimmel wrote:
> > From: Ido Schimmel <idosch@...dia.com>
> > 
> > The nexthop notification chain is a per-namespace chain and not a global
> > one like the netdev notification chain.
> > 
> > Therefore, a single (global) listener cannot be registered to all these
> > chains simultaneously as it will result in list corruptions whenever
> > listeners are registered / unregistered.
> > 
> > Instead, register a different listener in each namespace.
> > 
> > Currently this is not an issue because only the VXLAN driver registers a
> > listener to this chain, but this is going to change with netdevsim and
> > mlxsw also registering their own listeners.
> > 
> > Signed-off-by: Ido Schimmel <idosch@...dia.com>
> 
> Reviewed-by: David Ahern <dsahern@...nel.org>

Applied, thanks!