netdev - Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-11-02

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201103140440.5dba8402@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 3 Nov 2020 14:04:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
        netdev@...r.kernel.org, sassmann@...hat.com
Subject: Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver
 Updates 2020-11-02

On Mon, 02 Nov 2020 14:58:08 -0800 Saeed Mahameed wrote:
> On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote:
> > This series contains updates to ice driver only.  
> 
> ...
> 
> > Tony renames Flow Director functions to be more generic as their use
> > is expanded.
> > 
> > Real expands ntuple support to allow for mask values to be specified.
> > This
> > is done by implementing ACL filtering in HW.
> >   
> 
> This is a lot of code with only 2 liner commit messages!
> 
> Can you please shed more light on what user interface is being used to
> program and manage those ACLs, i see it is ethtool from the code but
> the cover letter and commit messages do not provide any information 
> about that.
> 
> Also could you please explain what ethtool interfaces/commands are
> being implemented, in the commit messages or cover letter, either is
> fine.

Please remove the defensive programming checks, and preferably slim
down the use of your special return codes.