netdev - Re: [PATCH net-next] ibmvnic: merge do_change_param_reset into do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63365b7e683e2c3b1b8e41c51668b401@linux.vnet.ibm.com>
Date:   Wed, 04 Nov 2020 13:56:09 -0800
From:   drt <drt@...ux.vnet.ibm.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Lijun Pan <ljp@...ux.ibm.com>, netdev@...r.kernel.org,
        sukadev@...ux.ibm.com, drt@...ux.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: merge do_change_param_reset into
 do_reset

On 2020-11-03 15:09, Jakub Kicinski wrote:
> On Sat, 31 Oct 2020 04:46:45 -0500 Lijun Pan wrote:
>> Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so
>> linkwatch_event can run") introduced do_change_param_reset function to
>> solve the rtnl lock issue. Majority of the code in 
>> do_change_param_reset
>> duplicates do_reset. Also, we can handle the rtnl lock issue in 
>> do_reset
>> itself. Hence merge do_change_param_reset back into do_reset to clean 
>> up
>> the code.
>> 
>> Fixes: b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so 
>> linkwatch_event can run")
>> Signed-off-by: Lijun Pan <ljp@...ux.ibm.com>
> 
> Applied, thanks!

Hi Jakub,

Thank you for applying this patch so promptly. However, I would like to 
ask that this patch be withdrawn.

1. It needs more time in testing.
2. There are a number of bug fix patches being tested. This patch would 
require rework of those patches.
3. As the lead maintainer for ibmvnic, I failed to communicate this to 
Lijun. I will do better going forward.

Please revert this commit. We will resubmit this patch later.

I sincerely apologize for any trouble this may have caused.

Regards,
Dany