netdev - Re: [PATCH net-next 1/3] ptp: idt82p33: add adjphase support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104135608.4314186f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 4 Nov 2020 13:56:08 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     <min.li.xe@...esas.com>
Cc:     <richardcochran@...il.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/3] ptp: idt82p33: add adjphase support

On Wed, 4 Nov 2020 11:01:47 -0500 min.li.xe@...esas.com wrote:
> From: Min Li <min.li.xe@...esas.com>
> 
> Add idt82p33_adjphase() to support PHC write phase mode.
> 
> Signed-off-by: Min Li <min.li.xe@...esas.com>

This appears to break the build. Each patch must build, otherwise we're
risking breaking builds when people bisect bugs with git bisect.

../drivers/ptp/ptp_idt82p33.c: In function ‘idt82p33_page_offset’:
../drivers/ptp/ptp_idt82p33.c:120:8: error: implicit declaration of function ‘_idt82p33_xfer’; did you mean ‘idt82p33_xfer’? [-Werror=implicit-function-declaration]
  120 |  err = _idt82p33_xfer(idt82p33, PAGE_ADDR, &val, sizeof(val), 1);
      |        ^~~~~~~~~~~~~~
      |        idt82p33_xfer
cc1: some warnings being treated as errors
make[3]: *** [drivers/ptp/ptp_idt82p33.o] Error 1
make[2]: *** [drivers/ptp] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [__sub-make] Error 2
../drivers/ptp/ptp_idt82p33.c: In function ‘idt82p33_page_offset’:
../drivers/ptp/ptp_idt82p33.c:120:8: error: implicit declaration of function ‘_idt82p33_xfer’; did you mean ‘idt82p33_xfer’? [-Werror=implicit-function-declaration]
  120 |  err = _idt82p33_xfer(idt82p33, PAGE_ADDR, &val, sizeof(val), 1);
      |        ^~~~~~~~~~~~~~
      |        idt82p33_xfer
cc1: some warnings being treated as errors
make[3]: *** [drivers/ptp/ptp_idt82p33.o] Error 1
make[2]: *** [drivers/ptp] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [__sub-make] Error 2