netdev - Re: [RFC PATCH ethtool] ethtool: Improve compatibility between netlink and ioctl interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104100515.GA988778@shredder>
Date:   Wed, 4 Nov 2020 12:05:15 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, mlxsw@...dia.com,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [RFC PATCH ethtool] ethtool: Improve compatibility between
 netlink and ioctl interfaces

On Wed, Nov 04, 2020 at 12:55:01AM +0100, Michal Kubecek wrote:
> On Tue, Nov 03, 2020 at 04:24:30PM +0200, Ido Schimmel wrote:
> > 
> > I have the changes you requested here:
> > https://github.com/idosch/ethtool/commit/b34d15839f2662808c566c04eda726113e20ee59
> > 
> > Do you want to integrate it with your nl_parse() rework or should I?
> 
> I pushed the combined series to
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/mkubecek/ethtool.git
> 
> as branch mk/master/advertise-all. I only ran few quick tests so far,
> it's not submission ready yet.
> 
> First two patches are unrelated fixes found while testing, I'm going to
> submit and push them separately. Third patch reworks nl_parser()
> handling of multiple request messages as indicated in my previous mail.
> Fourth patch is the ioctl compatibility fix.

Great, thank you. I pushed the patches to our regression. Will go over
the results tomorrow and let you know.