netdev - Re: [PATCH net-next v2] net: sched: implement action-specific terse dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104163916.4cf9b2dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 4 Nov 2020 16:39:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vlad Buslov <vlad@...lov.dev>
Cc:     jhs@...atatu.com, netdev@...r.kernel.org, davem@...emloft.net,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next v2] net: sched: implement action-specific terse
 dump

On Mon,  2 Nov 2020 22:12:43 +0200 Vlad Buslov wrote:
> Allow user to request action terse dump with new flag value
> TCA_FLAG_TERSE_DUMP. Only output essential action info in terse dump (kind,
> stats, index and cookie, if set by the user when creating the action). This
> is different from filter terse dump where index is excluded (filter can be
> identified by its own handle).
> 
> Move tcf_action_dump_terse() function to the beginning of source file in
> order to call it from tcf_dump_walker().
> 
> Signed-off-by: Vlad Buslov <vlad@...lov.dev>
> Suggested-by: Jamal Hadi Salim <jhs@...atatu.com>

Jiri, Cong, can I get an ack?

The previous terse dump made sense because it fulfilled the need of 
an important user (OvS). IDK if this is as clear-cut, and I haven't
followed the iproute2 thread closely enough, so please weigh in.