netdev - [PATCH] net/l2tp: remove unused macros to tame gcc warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri,  6 Nov 2020 13:29:54 +0800
From:   Alex Shi <alex.shi@...ux.alibaba.com>
To:     davem@...emloft.net
Cc:     Jakub Kicinski <kuba@...nel.org>, Tom Parkin <tparkin@...alix.com>,
        James Chapman <jchapman@...alix.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] net/l2tp: remove unused macros to tame gcc warning

There some unused macros cause gcc complain:

net/l2tp/l2tp_core.c:73:0: warning: macro "L2TP_HDRFLAG_P" is not used
[-Wunused-macros]
net/l2tp/l2tp_core.c:80:0: warning: macro "L2TP_SLFLAG_S" is not used
[-Wunused-macros]
net/l2tp/l2tp_core.c:81:0: warning: macro "L2TP_SL_SEQ_MASK" is not used
[-Wunused-macros]

Let's remove them to tame gcc.

Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
Cc: "David S. Miller" <davem@...emloft.net> 
Cc: Jakub Kicinski <kuba@...nel.org> 
Cc: Tom Parkin <tparkin@...alix.com> 
Cc: James Chapman <jchapman@...alix.com> 
Cc: netdev@...r.kernel.org 
Cc: linux-kernel@...r.kernel.org 
---
 net/l2tp/l2tp_core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index 7be5103ff2a8..672a53f602b5 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -73,16 +73,11 @@
 #define L2TP_HDRFLAG_L	   0x4000
 #define L2TP_HDRFLAG_S	   0x0800
 #define L2TP_HDRFLAG_O	   0x0200
-#define L2TP_HDRFLAG_P	   0x0100
 
 #define L2TP_HDR_VER_MASK  0x000F
 #define L2TP_HDR_VER_2	   0x0002
 #define L2TP_HDR_VER_3	   0x0003
 
-/* L2TPv3 default L2-specific sublayer */
-#define L2TP_SLFLAG_S	   0x40000000
-#define L2TP_SL_SEQ_MASK   0x00ffffff
-
 #define L2TP_HDR_SIZE_MAX		14
 
 /* Default trace flags */
-- 
1.8.3.1