netdev - Re: [PATCH net-next v3 03/15] net/smc: Add connection counters for links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201107095733.7a381e84@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 7 Nov 2020 09:57:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Karsten Graul <kgraul@...ux.ibm.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, hca@...ux.ibm.com, raspl@...ux.ibm.com
Subject: Re: [PATCH net-next v3 03/15] net/smc: Add connection counters for
 links

On Sat,  7 Nov 2020 13:59:46 +0100 Karsten Graul wrote:
> +static inline void smc_switch_link_and_count(struct smc_connection *conn,
> +					     struct smc_link *to_lnk)

Please avoid the use of static inline functions.

The compiler should inline this 3 instruction function anyway.

Please fix other instances in this submission as well.

> +{
> +	atomic_dec(&conn->lnk->conn_cnt);
> +	conn->lnk = to_lnk;
> +	atomic_inc(&conn->lnk->conn_cnt);
> +}