netdev - Re: [PATCH net-next v3 15/15] net/smc: Add support for obtaining system information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22bd2535-4057-12a2-ae6b-fefd33129e98@linux.ibm.com>
Date:   Mon, 9 Nov 2020 11:01:57 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, hca@...ux.ibm.com, raspl@...ux.ibm.com
Subject: Re: [PATCH net-next v3 15/15] net/smc: Add support for obtaining
 system information

On 07/11/2020 18:55, Jakub Kicinski wrote:
> On Sat,  7 Nov 2020 13:59:58 +0100 Karsten Graul wrote:
>> From: Guvenc Gulce <guvenc@...ux.ibm.com>
>>
>> Add new netlink command to obtain system information
>> of the smc module.
>>
>> Signed-off-by: Guvenc Gulce <guvenc@...ux.ibm.com>
>> Signed-off-by: Karsten Graul <kgraul@...ux.ibm.com>
> 
> Checkpatch says:
> 
> CHECK: Please don't use multiple blank lines
> #62: FILE: include/uapi/linux/smc_diag.h:140:
>  
> +
> 
> WARNING: line length of 84 exceeds 80 columns
> #172: FILE: net/smc/smc_diag.c:687:
> +	smcd_dev = list_first_entry_or_null(&dev_list->list, struct smcd_dev, list);
> 

The checkpatch.pl script in net-next does not bring up this length warning.
We will address it in a v4.

-- 
Karsten

(I'm a dude)