netdev - Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTVgw3hN=ffb88hYrOy5jD1W+V1XKDtd_Rs2mkoOSGj5Vw@mail.gmail.com>
Date:   Sun, 8 Nov 2020 03:16:37 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     Arend Van Spriel <arend.vanspriel@...adcom.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Netdev <netdev@...r.kernel.org>,
        David Laight <David.Laight@...lab.com>,
        Johannes Berg <johannes@...solutions.net>,
        Nicolai Stange <nstange@...e.de>, derosier@...il.com,
        Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless@...r.kernel.org, wil6210@....qualcomm.com,
        b43-dev@...ts.infradead.org, linux-bluetooth@...r.kernel.org,
        michael.hennerich@...log.com, linux-wpan@...r.kernel.org,
        stefan@...enfreihafen.org, inaky.perez-gonzalez@...el.com,
        linux-wimax@...el.com, emmanuel.grumbach@...el.com,
        Luciano Coelho <luciano.coelho@...el.com>, stf_xl@...pl,
        pkshih@...ltek.com, ath11k@...ts.infradead.org,
        ath10k@...ts.infradead.org, wcn36xx@...ts.infradead.org,
        merez@...eaurora.org, pizza@...ftnet.org,
        Larry Finger <Larry.Finger@...inger.net>, amitkarwar@...il.com,
        ganapathi.bhat@....com, huxinming820@...il.com,
        marcel@...tmann.org, johan.hedberg@...il.com, alex.aring@...il.com,
        jukka.rissanen@...ux.intel.com, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, chung-hsien.hsu@...ineon.com,
        wright.feng@...ineon.com, chi-hsien.lin@...ineon.com
Subject: Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE

On Sun, 8 Nov 2020 at 02:41, Arend Van Spriel
<arend.vanspriel@...adcom.com> wrote:
>

Hi Arend,
Thank you for the review!

> On November 7, 2020 6:25:15 PM Taehee Yoo <ap420073@...il.com> wrote:
>
> > If THIS_MODULE is not set, the module would be removed while debugfs is
> > being used.
> > It eventually makes kernel panic.
>
> Is this really a valid concern in the context of debugs? I tend to say it
> is not. Whenever I am using debugs to debug my driver I make sure to avoid
> removing it.

I think getting rid of every scenario of the kernel panic is the
first priority thing.
So I'm sure that trying to avoid kernel panic is always valid even
in the debugging context.

Thanks a lot!
Taehee Yoo