netdev - Re: [PATCH net v2 00/21] net: avoid to remove module when its debugfs is being used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201107110522.2a796f1d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 7 Nov 2020 11:05:22 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Taehee Yoo <ap420073@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        David.Laight@...lab.com, johannes@...solutions.net,
        nstange@...e.de, derosier@...il.com, kvalo@...eaurora.org,
        linux-wireless@...r.kernel.org, wil6210@....qualcomm.com,
        b43-dev@...ts.infradead.org, linux-bluetooth@...r.kernel.org,
        michael.hennerich@...log.com, linux-wpan@...r.kernel.org,
        stefan@...enfreihafen.org, inaky.perez-gonzalez@...el.com,
        linux-wimax@...el.com, emmanuel.grumbach@...el.com,
        luciano.coelho@...el.com, stf_xl@...pl, pkshih@...ltek.com,
        ath11k@...ts.infradead.org, ath10k@...ts.infradead.org,
        wcn36xx@...ts.infradead.org, merez@...eaurora.org,
        pizza@...ftnet.org, Larry.Finger@...inger.net,
        amitkarwar@...il.com, ganapathi.bhat@....com,
        huxinming820@...il.com, marcel@...tmann.org,
        johan.hedberg@...il.com, alex.aring@...il.com,
        jukka.rissanen@...ux.intel.com, arend.vanspriel@...adcom.com,
        franky.lin@...adcom.com, hante.meuleman@...adcom.com,
        chung-hsien.hsu@...ineon.com, wright.feng@...ineon.com,
        chi-hsien.lin@...ineon.com
Subject: Re: [PATCH net v2 00/21] net: avoid to remove module when its
 debugfs is being used

On Sat,  7 Nov 2020 17:21:31 +0000 Taehee Yoo wrote:
> When debugfs file is opened, its module should not be removed until
> it's closed.
> Because debugfs internally uses the module's data.
> So, it could access freed memory.
> 
> In order to avoid panic, it just sets .owner to THIS_MODULE.
> So that all modules will be held when its debugfs file is opened.

Hm, looks like some of the patches need to be revised because
.owner is already set in the ops, and a warning gets generated.

Also it'd be good to mention why Johannes's approach was abandoned.

When you repost please separate out all the patches for
drivers/net/wireless/ and send that to Kalle's wireless drivers tree.
Patch 1 needs to be split in two. Patches 2 and 3 would go via Johannes.
The wimax patch needs to go to staging (wimax code has been moved).
The remaining patches can be posted individually, not as a series.