netdev - Re: [PATCH net-next v7 0/5] net: hdlc_fr: Improve fr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJht_EPvPW8tSGbhB99c_SpZ7c30yP23Z-tW-6+YjBP8aacr0w@mail.gmail.com>
Date:   Sat, 7 Nov 2020 06:34:05 -0800
From:   Xie He <xie.he.0141@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Krzysztof Halasa <khc@...waw.pl>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next v7 0/5] net: hdlc_fr: Improve fr_rx and add
 support for any Ethertype

On Tue, Nov 3, 2020 at 6:03 PM Xie He <xie.he.0141@...il.com> wrote:
>
> On Tue, Nov 3, 2020 at 3:22 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > Applied, but going forward please limit any refactoring and extensions
> > to the HDLC code. I thought you are actually using it. If that's not
> > the case let's leave the code be, it's likely going to be removed in
> > a few years time.
>
> OK. I understand.
>
> Thanks!

The HDLC layer is still used by X.25 people (to be precise, Martin
Schiller <ms@....tdt.de>). Although we currently have three X.25
drivers in the kernel (lapbether, x25_asy, hdlc_x25), it seems to me
that only hdlc_x25 is used in the real world. So I guess the HDLC
layer will be there as long as the X.25 stack is still there.