netdev - Re: [PATCH] pcp_clock: return EOPNOTSUPP if !CONFIG_PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201107145646.GA9653@hoboy.vegasvil.org>
Date:   Sat, 7 Nov 2020 06:56:46 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     Wang Qing <wangqing@...o.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pcp_clock: return EOPNOTSUPP if !CONFIG_PTP_1588_CLOCK

On Sat, Nov 07, 2020 at 11:28:23AM +0800, Wang Qing wrote:
> pcp_clock_register() is checked with IS_ERR(), and will crash if !PTP,
> change return value to ERR_PTR(-EOPNOTSUPP) for the !CONFIG_PTP_1588_CLOCK
>  and so question resolved.

NAK.

Drivers must use the documented interface.

Thanks,
Richard