netdev - Re: [PATCH net V2] Exempt multicast addresses from five-second neighbor lifetime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aaf62231-75d2-6b2f-9982-3d24ca4e4e80@akamai.com>
Date:   Tue, 10 Nov 2020 09:21:53 -0500
From:   Jeff Dike <jdike@...mai.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>
Subject: Re: [PATCH net V2] Exempt multicast addresses from five-second
 neighbor lifetime

Hi Jakub,

On 11/9/20 2:47 PM, Jakub Kicinski wrote:
> This makes sense because mcast L2 addr is calculated, not discovered,
> and therefore can be recreated at a very low cost, correct?

Yes.

> Perhaps it would make sense to widen the API to any "computed" address
> rather than implicitly depending on this behavior for mcast?

I'm happy to do that, but I don't know of any other types of addresses which are computed and end up in the neighbors table.

> I'm not an expert tho, maybe others disagree.
> 
>> +static int arp_is_multicast(const void *pkey)
>> +{
>> +	return IN_MULTICAST(htonl(*((u32 *)pkey)));
>> +}
> 
> net/ipv4/arp.c:935:16: warning: cast from restricted __be32
> 
> s/u32/__be32/
> s/htonl/ntohl/

Thanks, I ran sparse, but must have missed that somehow.

Jeff