netdev - Re: [PATCH net V2] Exempt multicast addresses from five-second neighbor lifetime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50c52b3b-9bf3-6666-df4f-a30cbffd208f@gmail.com>
Date:   Mon, 9 Nov 2020 20:55:59 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jeff Dike <jdike@...mai.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net V2] Exempt multicast addresses from five-second
 neighbor lifetime

in addition to Jakub's comments ...

On 11/8/20 7:50 PM, Jeff Dike wrote:
> @@ -1706,6 +1708,11 @@ static void pndisc_redo(struct sk_buff *skb)
>  	kfree_skb(skb);
>  }
>  
> +static int ndisc_is_multicast(const void *pkey)
> +{
> +	return (((struct in6_addr *)pkey)->in6_u.u6_addr8[0] & 0xf0) == 0xf0;

ipv6_addr_type() and IPV6_ADDR_MULTICAST is the better way to code this.



> +}
> +
>  static bool ndisc_suppress_frag_ndisc(struct sk_buff *skb)
>  {
>  	struct inet6_dev *idev = __in6_dev_get(skb->dev);
>