[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 11 Nov 2020 14:11:25 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ioana Ciornei <ciorneiioana@...il.com>
Cc: netdev@...r.kernel.org, Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH net-next] net: phy: aquantia: do not return an error on
clearing pending IRQs
On Mon, 9 Nov 2020 17:46:01 +0200 Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@....com>
>
> The referenced commit added in .config_intr() the part of code which upon
> configuration of the IRQ state it also clears up any pending IRQ. If
> there were actually pending IRQs, a read on the IRQ status register will
> return something non zero. This should not result in the callback
> returning an error.
>
> Fix this by returning an error only when the result of the
> phy_read_mmd() is negative.
>
> Fixes: e11ef96d44f1 ("net: phy: aquantia: remove the use of .ack_interrupt()")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
Applied, thanks!
Powered by blists - more mailing lists