netdev - Re: [PATCH net/next] net: ipconfig: Avoid spurious blank lines in boot log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201112145520.45f13da3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 12 Nov 2020 14:55:20 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH net/next] net: ipconfig: Avoid spurious blank lines in
 boot log

On Tue, 10 Nov 2020 08:37:57 +0100 Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> When dumping the name and NTP servers advertised by DHCP, a blank line
> is emitted if either of the lists is empty. This can lead to confusing
> issues such as the blank line getting flagged as warning. This happens
> because the blank line is the result of pr_cont("\n") and that may see
> its level corrupted by some other driver concurrently writing to the
> console.
> 
> Fix this by making sure that the terminating newline is only emitted
> if at least one entry in the lists was printed before.
> 
> Reported-by: Jon Hunter <jonathanh@...dia.com>
> Signed-off-by: Thierry Reding <treding@...dia.com>

Applied, thanks!