netdev - Re: [PATCH netdev 2/2] virtio, xdp: Allow xdp to load, even if there is not enough queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <09cbe8ac-34ec-3945-88f4-a31e863c44f7@redhat.com>
Date:   Fri, 13 Nov 2020 09:06:52 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
        john.fastabend@...il.com, mst@...hat.com, davem@...emloft.net,
        kuba@...nel.org
Subject: Re: [PATCH netdev 2/2] virtio, xdp: Allow xdp to load, even if there
 is not enough queue


On 2020/11/12 下午5:15, Xuan Zhuo wrote:
> Since XDP_TX uses an independent queue to send data by default, and
> requires a queue for each CPU, this condition is often not met when the
> number of CPUs is relatively large, but XDP_TX is not used in many
> cases. I hope In this case, XDP is allowed to load and a warning message
> is submitted. If the user uses XDP_TX, another error is generated.
>
> This is not a perfect solution, but I still hope to solve some of the
> problems first.
>
> Signed-off-by: Xuan Zhuo<xuanzhuo@...ux.alibaba.com>


This leads bad user experiences.

Let's do something like this:

1) When TX queues is sufficient, go as in the past
2) When TX queue is not, use tx lock to synchronize

Thanks