[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJKOXPePgqWQpJjOeJ9U0jcNG7et6heAid2HnrPeWTDKXLUgjA@mail.gmail.com>
Date: Fri, 13 Nov 2020 08:25:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: bongsu.jeon@...sung.com
Cc: "kuba@...nel.org" <kuba@...nel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] nfc: s3fwrn82: Add driver for Samsung
S3FWRN82 NFC Chip
On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon <bongsu.jeon@...sung.com> wrote:
>
>
> Add driver for Samsung S3FWRN82 NFC controller.
> S3FWRN82 is using NCI protocol and I2C communication interface.
>
> Signed-off-by: Bongsu Jeon <bongsu.jeon@...sung.com>
> ---
> drivers/nfc/Kconfig | 1 +
> drivers/nfc/Makefile | 1 +
> drivers/nfc/s3fwrn82/Kconfig | 15 ++
> drivers/nfc/s3fwrn82/Makefile | 10 ++
> drivers/nfc/s3fwrn82/core.c | 133 +++++++++++++++
> drivers/nfc/s3fwrn82/i2c.c | 288 ++++++++++++++++++++++++++++++++
> drivers/nfc/s3fwrn82/s3fwrn82.h | 86 ++++++++++
> 7 files changed, 534 insertions(+)
> create mode 100644 drivers/nfc/s3fwrn82/Kconfig
> create mode 100644 drivers/nfc/s3fwrn82/Makefile
> create mode 100644 drivers/nfc/s3fwrn82/core.c
> create mode 100644 drivers/nfc/s3fwrn82/i2c.c
> create mode 100644 drivers/nfc/s3fwrn82/s3fwrn82.h
No, this is a copy of existing s3fwrn5.
Please do not add drivers which are duplicating existing ones but
instead work on extending them.
Best regards,
Krzysztof
Powered by blists - more mailing lists