netdev - Re: [PATCH net-next 2/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPez5ZbuG3jgjNbhAbDrWoDa+UGAiRpi_fjSpB=D6geo6A@mail.gmail.com>
Date:   Fri, 13 Nov 2020 08:28:14 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     bongsu.jeon@...sung.com
Cc:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] nfc: s3fwrn82: Add driver for Samsung
 S3FWRN82 NFC Chip

On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon <bongsu.jeon@...sung.com> wrote:
>
>
> Add the device tree bindings for Samsung S3FWRN82 NFC controller.
> S3FWRN82 is using NCI protocol and I2C communication interface.
>
> Signed-off-by: Bongsu Jeon <bongsu.jeon@...sung.com>
> ---
>  .../devicetree/bindings/net/nfc/s3fwrn82.txt  | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt
>
> diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt
> new file mode 100644
> index 000000000000..03ed880e1c7f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn82.txt
> @@ -0,0 +1,30 @@
> +* Samsung S3FWRN82 NCI NFC Controller
> +
> +Required properties:
> +- compatible: Should be "samsung,s3fwrn82-i2c".
> +- reg: address on the bus
> +- interrupts: GPIO interrupt to which the chip is connected
> +- en-gpios: Output GPIO pin used for enabling/disabling the chip
> +- wake-gpios: Output GPIO pin used to enter firmware mode and
> +  sleep/wakeup control
> +

The bindings should be the first file in the series. However it does
not really matter as this patch should be part of the existing s3fwrn5
driver.

When submitting bindings, please use the title to match the bindings
and use YAML format.

Best regards,
Krzysztof