netdev - Re: [PATCH net-next] r8169: improve rtl8169_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201116075803.0a75fd3f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 16 Nov 2020 07:58:03 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: improve rtl8169_start_xmit

On Sat, 14 Nov 2020 21:49:53 +0100 Heiner Kallweit wrote:
> Improve the following in rtl8169_start_xmit:
> - tp->cur_tx can be accessed in parallel by rtl_tx(), therefore
>   annotate the race by using WRITE_ONCE
> - avoid checking stop_queue a second time by moving the doorbell check
> - netif_stop_queue() uses atomic operation set_bit() that includes a
>   full memory barrier on some platforms, therefore use
>   smp_mb__after_atomic to avoid overhead
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks.