netdev - Re: [PATCH net-next] r8169: remove nr_frags argument from rtl_tx_slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201116075919.7add7001@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 16 Nov 2020 07:59:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: remove nr_frags argument from
 rtl_tx_slots_avail

On Sun, 15 Nov 2020 21:55:32 +0100 Heiner Kallweit wrote:
> The only time when nr_frags isn't SKB_MAX_FRAGS is when entering
> rtl8169_start_xmit(). However we can use SKB_MAX_FRAGS also here
> because when queue isn't stopped there should always be room for
> MAX_SKB_FRAGS + 1 descriptors.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Looks like this depended on the patch I just applied, please try avoid
this sort of dependencies, the bot can't test this.

Now the prerequisite is applied please resend.