[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAADnVQ+LNBYq5fdTSRUPy2ZexTdCcB6ErNH_T=r9bJ807UT=pQ@mail.gmail.com>
Date: Sun, 15 Nov 2020 23:19:26 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Hangbin Liu <haliu@...hat.com>
Cc: Stephen Hemminger <stephen@...workplumber.org>,
David Ahern <dsahern@...il.com>,
Daniel Borkmann <daniel@...earbox.net>,
Martin KaFai Lau <kafai@...com>,
Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
David Miller <davem@...emloft.net>,
Jesper Dangaard Brouer <brouer@...hat.com>,
Network Development <netdev@...r.kernel.org>,
bpf <bpf@...r.kernel.org>, Jiri Benc <jbenc@...hat.com>,
Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCHv5 iproute2-next 0/5] iproute2: add libbpf support
On Sun, Nov 15, 2020 at 10:56 PM Hangbin Liu <haliu@...hat.com> wrote:
>
> This series converts iproute2 to use libbpf for loading and attaching
> BPF programs when it is available. This means that iproute2 will
> correctly process BTF information and support the new-style BTF-defined
> maps, while keeping compatibility with the old internal map definition
> syntax.
>
> This is achieved by checking for libbpf at './configure' time, and using
> it if available. By default the system libbpf will be used, but static
> linking against a custom libbpf version can be achieved by passing
> LIBBPF_DIR to configure. LIBBPF_FORCE can be set to on to force configure
> abort if no suitable libbpf is found (useful for automatic packaging
> that wants to enforce the dependency), or set off to disable libbpf check
> and build iproute2 with legacy bpf.
>
> The old iproute2 bpf code is kept and will be used if no suitable libbpf
> is available. When using libbpf, wrapper code ensures that iproute2 will
> still understand the old map definition format, including populating
> map-in-map and tail call maps before load.
>
> The examples in bpf/examples are kept, and a separate set of examples
> are added with BTF-based map definitions for those examples where this
> is possible (libbpf doesn't currently support declaratively populating
> tail call maps).
>
> At last, Thanks a lot for Toke's help on this patch set.
>
> v5:
> a) Fix LIBBPF_DIR typo and description, use libbpf DESTDIR as LIBBPF_DIR
> dest.
> b) Fix bpf_prog_load_dev typo.
> c) rebase to latest iproute2-next.
For the reasons explained multiple times earlier:
Nacked-by: Alexei Starovoitov <ast@...nel.org>
Powered by blists - more mailing lists