netdev - Re: [PATCH net] enetc: Workaround for MDIO register access issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201118090343.7bbf0047@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Wed, 18 Nov 2020 09:03:43 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net] enetc: Workaround for MDIO register access issue

On Wed, 18 Nov 2020 19:00:44 +0200 Vladimir Oltean wrote:
> On Wed, Nov 18, 2020 at 02:38:56PM +0100, Andrew Lunn wrote:
> > Thanks for the explanation. I don't think i've every reviewed a driver
> > using read/write locks like this. But thinking it through, it does
> > seem O.K.  
> 
> Thanks for reviewing and getting this merged. It sure is helpful to not
> have the link flap while running iperf3 or other intensive network
> activity.
> 
> Even if this use of rwlocks may seem unconventional, I think it is the
> right tool for working around the hardware bug.

Out of curiosity - did you measure the performance hit?