netdev - Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Nov 2020 19:49:16 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Mat Martineau <mathew.j.martineau@...ux.intel.com>
Cc:     Paolo Abeni <pabeni@...hat.com>, Netdev <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>, mptcp@...ts.01.org
Subject: Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

On Thu, 19 Nov 2020 at 06:13, Mat Martineau
<mathew.j.martineau@...ux.intel.com> wrote:
>
>
> On Wed, 18 Nov 2020, Paolo Abeni wrote:
>
> > We must start the retransmission timer only there are
> > pending data in the rtx queue.
> > Otherwise we can hit a WARN_ON in mptcp_reset_timer(),
> > as syzbot demonstrated.
> >
> > Reported-and-tested-by: syzbot+42aa53dafb66a07e5a24@...kaller.appspotmail.com
> > Fixes: d9ca1de8c0cd ("mptcp: move page frag allocation in mptcp_sendmsg()")
> > Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> > ---
> > net/mptcp/protocol.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
>
> Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
Tested-by: Naresh Kamboju <naresh.kamboju@...aro.org>

The reported kernel warning was fixed after applying this fix on top of
Linux next tag  20201119.

- Naresh