netdev - Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201119215533.1dff6751@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 19 Nov 2020 21:55:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Netdev <netdev@...r.kernel.org>, mptcp@...ts.01.org
Subject: Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if
 required.

On Thu, 19 Nov 2020 19:49:16 +0530 Naresh Kamboju wrote:
> > > We must start the retransmission timer only there are
> > > pending data in the rtx queue.
> > > Otherwise we can hit a WARN_ON in mptcp_reset_timer(),
> > > as syzbot demonstrated.
> > >
> > > Reported-and-tested-by: syzbot+42aa53dafb66a07e5a24@...kaller.appspotmail.com
> > > Fixes: d9ca1de8c0cd ("mptcp: move page frag allocation in mptcp_sendmsg()")
> > > Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> >
> > Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>  
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Tested-by: Naresh Kamboju <naresh.kamboju@...aro.org>

Applied, thanks!