netdev - Re: [PATCH] net: mvpp2: divide fifo for dts-active ports only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201120121150.4347bb76@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 20 Nov 2020 12:11:50 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     <stefanc@...vell.com>
Cc:     <netdev@...r.kernel.org>, <thomas.petazzoni@...tlin.com>,
        <davem@...emloft.net>, <nadavh@...vell.com>, <ymarkman@...vell.com>
Subject: Re: [PATCH] net: mvpp2: divide fifo for dts-active ports only

On Wed, 18 Nov 2020 20:20:56 +0200 stefanc@...vell.com wrote:
> From: Stefan Chulski <stefanc@...vell.com>
> 
> Tx/Rx FIFO is a HW resource limited by total size, but shared
> by all ports of same CP110 and impacting port-performance.
> Do not divide the FIFO for ports which are not enabled in DTS,
> so active ports could have more FIFO.
> 
> The active port mapping should be done in probe before FIFO-init.
> 
> Signed-off-by: Stefan Chulski <stefanc@...vell.com>

Looks good to me, but it seems you're missing more people from the CC
list.

Could you please repost and CC at least Russell?

Russell King <rmk+kernel@...linux.org.uk>

scripts/get_maintainer.pl is your friend.

> +static void mvpp22_rx_fifo_init(struct mvpp2 *priv)
> +{
> +	int port, size;
> +	unsigned long port_map;
> +	int remaining_ports_count;
> +	int size_remainder;

>  static void mvpp22_tx_fifo_init(struct mvpp2 *priv)
>  {
> +	int port, size;
> +	unsigned long port_map;
> +	int remaining_ports_count;
> +	int size_remainder;

Since you're reposting please reorder the variable declaration lines
longest to shortest (reverse xmas tree).