netdev - Re: Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201125150100.287ac72a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 25 Nov 2020 15:01:00 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Thomas Karlsson <thomas.karlsson@...eda.se>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Hardcoded multicast queue length in macvlan.c driver causes
 poor multicast receive performance

On Wed, 25 Nov 2020 23:15:39 +0100 Thomas Karlsson wrote:
> >> This is my first time ever attemting a contribution to the kernel so
> >> I'm quite happy to keep it simple like that too :)  
> > 
> > Module params are highly inflexible, we have a general policy not 
> > to accept them in the netdev world.
> 
> I see, although the current define seems even less flexible :)

Just to be clear - the module parameter is a no-go. 
No point discussing it.

> Although, I might not have fully understood the .changelink you suggest.
> Is it via the ip link set ... command? 

Yes.

> Or is there a way to set the parameters in a more "raw" form that
> does not require a patch to iproute2 with parameter parsing, error
> handing, man pages updates, etc. I feel that I'm getting in over my
> head here.

We're here to assist! Netlink takes a little bit of effort 
to comprehend but it's very simple once you get the mechanics!