netdev - Re: [PATCH bpf-next v3 1/5] selftests/bpf: xsk selftests framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c73643f-0fdc-d867-6fe0-b3b8031a6cf2@fb.com>
Date:   Thu, 26 Nov 2020 20:19:49 -0800
From:   Yonghong Song <yhs@...com>
To:     Weqaar Janjua <weqaar.janjua@...il.com>,
        Björn Töpel <bjorn.topel@...el.com>
CC:     <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>, <ast@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        Weqaar Janjua <weqaar.a.janjua@...el.com>, <shuah@...nel.org>,
        <skhan@...uxfoundation.org>, <linux-kselftest@...r.kernel.org>,
        Anders Roxell <anders.roxell@...aro.org>,
        <jonathan.lemon@...il.com>
Subject: Re: [PATCH bpf-next v3 1/5] selftests/bpf: xsk selftests framework



On 11/26/20 1:22 PM, Weqaar Janjua wrote:
> On Thu, 26 Nov 2020 at 09:01, Björn Töpel <bjorn.topel@...el.com> wrote:
>>
>> On 2020-11-26 07:44, Yonghong Song wrote:
>>>
>> [...]
>>>
>>> What other configures I am missing?
>>>
>>> BTW, I cherry-picked the following pick from bpf tree in this experiment.
>>>     commit e7f4a5919bf66e530e08ff352d9b78ed89574e6b (HEAD -> xsk)
>>>     Author: Björn Töpel <bjorn.topel@...el.com>
>>>     Date:   Mon Nov 23 18:56:00 2020 +0100
>>>
>>>         net, xsk: Avoid taking multiple skbuff references
>>>
>>
>> Hmm, I'm getting an oops, unless I cherry-pick:
>>
>> 36ccdf85829a ("net, xsk: Avoid taking multiple skbuff references")
>>
>> *AND*
>>
>> 537cf4e3cc2f ("xsk: Fix umem cleanup bug at socket destruct")
>>
>> from bpf/master.
>>
> 
> Same as Bjorn's findings ^^^, additionally applying the second patch
> 537cf4e3cc2f [PASS] all tests for me
> 
> PREREQUISITES: [ PASS ]
> SKB NOPOLL: [ PASS ]
> SKB POLL: [ PASS ]
> DRV NOPOLL: [ PASS ]
> DRV POLL: [ PASS ]
> SKB SOCKET TEARDOWN: [ PASS ]
> DRV SOCKET TEARDOWN: [ PASS ]
> SKB BIDIRECTIONAL SOCKETS: [ PASS ]
> DRV BIDIRECTIONAL SOCKETS: [ PASS ]
> 
> With the first patch alone, as soon as we enter DRV/Native NOPOLL mode
> kernel panics, whereas in your case NOPOLL tests were falling with
> packets being *lost* as per seqnum mismatch.
> 
> Can you please test this out with both patches and let us know?

I applied both the above patches in bpf-next as well as this patch set,
I still see failures. I am attaching my config file. Maybe you can take
a look at what is the issue.

> 
>> Can I just run test_xsk.sh at tools/testing/selftests/bpf/ directory?
>> This will be easier than the above for bpf developers. If it does not
>> work, I would like to recommend to make it work.
>>
> yes test_xsk.shis self contained, will update the instructions in there with v4.

That will be great. Thanks!

> 
> Thanks,
> /Weqaar
>>
>> Björn

View attachment "xsk.config" of type "text/plain" (129220 bytes)