netdev - Re: [PATCH net-next 5/6] mptcp: avoid a few atomic ops in the rx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9ef28f7-814a-1a86-9337-a7d2eddb7754@linux.intel.com>
Date:   Mon, 30 Nov 2020 15:44:54 -0800 (PST)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        mptcp@...ts.01.org, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 5/6] mptcp: avoid a few atomic ops in the rx
 path

On Fri, 27 Nov 2020, Paolo Abeni wrote:

> Extending the data_lock scope in mptcp_incoming_option
> we can use that to protect both snd_una and wnd_end.
> In the typical case, we will have a single atomic op instead of 2
>
> Acked-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/mptcp_diag.c |  2 +-
> net/mptcp/options.c    | 33 +++++++++++++--------------------
> net/mptcp/protocol.c   | 34 ++++++++++++++++------------------
> net/mptcp/protocol.h   |  8 ++++----
> 4 files changed, 34 insertions(+), 43 deletions(-)

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel