netdev - Re: [PATCH net-next 6/6] mptcp: use mptcp release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98a5b8cf-4c8a-bd28-111-9261d743a3bd@linux.intel.com>
Date:   Mon, 30 Nov 2020 15:45:18 -0800 (PST)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        mptcp@...ts.01.org, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 6/6] mptcp: use mptcp release_cb for delayed
 tasks

On Fri, 27 Nov 2020, Paolo Abeni wrote:

> We have some tasks triggered by the subflow receive path
> which require to access the msk socket status, specifically:
> mptcp_clean_una() and mptcp_push_pending()
>
> We have almost everything in place to defer to the msk
> release_cb such tasks when the msk sock is owned.
>
> Since the worker is no more used to clean the acked data,
> for fallback sockets we need to explicitly flush them.
>
> As an added bonus we can move the wake-up code in __mptcp_clean_una(),
> simplify a lot mptcp_poll() and move the timer update under
> the data lock.
>
> The worker is now used only to process and send DATA_FIN
> packets and do the mptcp-level retransmissions.
>
> Acked-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/options.c  |  18 +++-
> net/mptcp/protocol.c | 250 ++++++++++++++++++++++++++-----------------
> net/mptcp/protocol.h |   3 +
> net/mptcp/subflow.c  |  14 +--
> 4 files changed, 168 insertions(+), 117 deletions(-)

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel