netdev - Re: [PATCH net-next] net: sched: remove redundant 'rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201130185222.6b24ed42@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Mon, 30 Nov 2020 18:52:22 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vlad Buslov <vladbu@...dia.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held'
 argument

On Fri, 27 Nov 2020 17:12:05 +0200 Vlad Buslov wrote:
> @@ -2262,7 +2260,7 @@ static int tc_del_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
>  
>  	if (prio == 0) {
>  		tfilter_notify_chain(net, skb, block, q, parent, n,
> -				     chain, RTM_DELTFILTER, rtnl_held);
> +				     chain, RTM_DELTFILTER);
>  		tcf_chain_flush(chain, rtnl_held);
>  		err = 0;
>  		goto errout;

Hum. This looks off.