netdev - Re: [PATCH iproute2-next 3/6] lib: Move sprint_size() from tc here, add print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26d00984-baf6-7d30-9edc-04dfd29193c6@gmail.com>
Date:   Tue, 1 Dec 2020 21:07:12 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <me@...chata.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, Po.Liu@....com, toke@...e.dk,
        dave.taht@...il.com, edumazet@...gle.com, tahiliani@...k.edu.in,
        leon@...nel.org
Subject: Re: [PATCH iproute2-next 3/6] lib: Move sprint_size() from tc here,
 add print_size()

On 12/1/20 3:41 PM, Petr Machata wrote:
> 
>> Also, instead of magic SPRINT_BSIZE, why not take a len param (and
>> name it snprint_size)?
> 
> Because keeping the interface like this makes it possible to reuse the
> macroized bits in q_cake. I feel like the three current users are
> auditable enough that the implied length is not a big deal. And no new
> users should pop up, as the comment at the function makes clear.
> 


seems reasonable and this reduces the number of users of sprint_size.