netdev - Re: [PATCH 2/4] net: stmmac: start phylink instance before stmmac_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201203103140.3a4e6125@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Thu, 3 Dec 2020 10:31:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH 2/4] net: stmmac: start phylink instance before
 stmmac_hw_setup()

On Wed,  2 Dec 2020 16:59:47 +0800 Joakim Zhang wrote:
> From: Fugang Duan <fugang.duan@....com>
> 
> Start phylink instance and resume back the PHY to supply
> RX clock to MAC before MAC layer initialization by calling
> .stmmac_hw_setup(), since DMA reset depends on the RX clock,
> otherwise DMA reset cost maximum timeout value then finally
> timeout.

We'll need a Fixes tag here.

> Signed-off-by: Fugang Duan <fugang.duan@....com>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>