lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Dec 2020 10:32:56 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Joakim Zhang <qiangqing.zhang@....com> Cc: peppe.cavallaro@...com, alexandre.torgue@...com, joabreu@...opsys.com, davem@...emloft.net, netdev@...r.kernel.org, linux-imx@....com Subject: Re: [PATCH 3/4] net: ethernet: stmmac: free tx skb buffer in stmmac_resume() On Wed, 2 Dec 2020 16:59:48 +0800 Joakim Zhang wrote: > From: Fugang Duan <fugang.duan@....com> > > When do suspend/resume test, there have WARN_ON() log dump from > stmmac_xmit() funciton, the code logic: > entry = tx_q->cur_tx; > first_entry = entry; > WARN_ON(tx_q->tx_skbuff[first_entry]); > > In normal case, tx_q->tx_skbuff[txq->cur_tx] should be NULL because > the skb should be handled and freed in stmmac_tx_clean(). > > But stmmac_resume() reset queue parameters like below, skb buffers > may not be freed. > tx_q->cur_tx = 0; > tx_q->dirty_tx = 0; > > So free tx skb buffer in stmmac_resume() to avoid warning and > memory leak. Also needs Fixes
Powered by blists - more mailing lists