netdev - Re: [PATCH 4/4] net: ethernet: stmmac: delete the eee_ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201203103345.45c6ef8d@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Thu, 3 Dec 2020 10:33:45 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH 4/4] net: ethernet: stmmac: delete the eee_ctrl_timer
 after napi disabled

On Wed,  2 Dec 2020 16:59:49 +0800 Joakim Zhang wrote:
> From: Fugang Duan <fugang.duan@....com>
> 
> There have chance to re-enable the eee_ctrl_timer and fire the timer
> in napi callback after delete the timer in .stmmac_release(), which
> introduces to access eee registers in the timer function after clocks
> are disabled then causes system hang. Found this issue when do
> suspend/resume and reboot stress test.
> 
> It is safe to delete the timer after napi disabled and disable lpi mode.

And here