netdev - Re: [Patch net] lwt: disable BH too in run_lwt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Dec 2020 18:00:10 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        Thomas Graf <tgraf@...g.ch>, bpf <bpf@...r.kernel.org>,
        Cong Wang <cong.wang@...edance.com>
Subject: Re: [Patch net] lwt: disable BH too in run_lwt_bpf()

On Thu, Dec 3, 2020 at 9:55 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Thu, Dec 3, 2020 at 10:30 AM Alexei Starovoitov
> <alexei.starovoitov@...il.com> wrote:
> >
> > On Thu, Dec 3, 2020 at 10:28 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
> > >
> > > On Thu, Dec 3, 2020 at 10:22 AM Alexei Starovoitov
> > > <alexei.starovoitov@...il.com> wrote:
> > > >
> > > > I guess my previous comment could be misinterpreted.
> > > > Cong,
> > > > please respin with changing preempt_disable to migrate_disable
> > > > and adding local_bh_disable.
> > >
> > > I have no objection, just want to point out migrate_disable() may
> > > not exist if we backport this further to -stable, this helper was
> > > introduced in Feb 2020.
> >
> > I see. Then please split it into two patches for ease of backporting.
>
> You mean the first patch does the same as this patch and the second
> patch replaces preempt_disable() with migrate_disable(). Right?

Right. Just be mindful of changing the comment.