netdev - Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202012072221.5dRNtwYy-lkp@intel.com>
Date:   Mon, 7 Dec 2020 22:11:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>,
        netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, andrew@...n.ch, f.fainelli@...il.com,
        davem@...emloft.net, kernel@...gutronix.de,
        matthias.schiffer@...tq-group.com, woojung.huh@...rochip.com,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register
 offsets and shifts to separate struct

Hi Michael,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20201207]
[cannot apply to net/master ipvs/master linus/master v5.10-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Michael-Grzeschik/microchip-add-support-for-ksz88x3-driver-family/20201207-205945
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git af3f4a85d90218bb59315d591bd2bffa5e646466
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/db1f7322c8fa2c28587f13ab3eebbb6ee02874b1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Grzeschik/microchip-add-support-for-ksz88x3-driver-family/20201207-205945
        git checkout db1f7322c8fa2c28587f13ab3eebbb6ee02874b1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/microchip/ksz8795.c:69:27: warning: initialized field overwritten [-Woverride-init]
      69 |  [DYNAMIC_MAC_ENTRIES]  = 29,
         |                           ^~
   drivers/net/dsa/microchip/ksz8795.c:69:27: note: (near initialization for 'ksz8795_shifts[5]')

vim +69 drivers/net/dsa/microchip/ksz8795.c

    62	
    63	static const u8 ksz8795_shifts[] = {
    64		[VLAN_TABLE_MEMBERSHIP]		= 7,
    65		[VLAN_TABLE]			= 16,
    66		[STATIC_MAC_FWD_PORTS]		= 16,
    67		[STATIC_MAC_FID]		= 24,
    68		[DYNAMIC_MAC_ENTRIES_H]		= 3,
  > 69		[DYNAMIC_MAC_ENTRIES]		= 29,
    70		[DYNAMIC_MAC_FID]		= 16,
    71		[DYNAMIC_MAC_TIMESTAMP]		= 27,
    72		[DYNAMIC_MAC_SRC_PORT]		= 24,
    73	};
    74	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (66553 bytes)