netdev - Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201207.070123.2205337287463864568.davem@davemloft.net>
Date:   Mon, 07 Dec 2020 07:01:23 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     m.grzeschik@...gutronix.de
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
        kernel@...gutronix.de, matthias.schiffer@...tq-group.com,
        woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register
 offsets and shifts to separate struct

From: Michael Grzeschik <m.grzeschik@...gutronix.de>
Date: Mon,  7 Dec 2020 13:56:24 +0100

> @@ -991,13 +1090,16 @@ static void ksz8_port_setup(struct ksz_device *dev, int port, bool cpu_port)
>  static void ksz8_config_cpu_port(struct dsa_switch *ds)
>  {
>  	struct ksz_device *dev = ds->priv;
> +	struct ksz8 *ksz8 = dev->priv;
> +	const u8 *regs = ksz8->regs;
> +	const u32 *masks = ksz8->masks;
>  	struct ksz_port *p;
>  	u8 remote;
>  	int i;
>  

Please use reverse christmas tree ordering for local variables.

Thank you.