lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Dec 2020 15:04:58 +0000 From: Ioana Ciornei <ioana.ciornei@....com> To: Christophe JAILLET <christophe.jaillet@...adoo.fr> CC: Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>, "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote: > Add an 'of_node_put()' call when a tested device node is not available. > > Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> Reviewed-by: Ioana Ciornei <ioana.ciornei@....com> Thanks! > --- > drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > index 90cd243070d7..828c177df03d 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > @@ -269,6 +269,7 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac, > > if (!of_device_is_available(node)) { > netdev_err(mac->net_dev, "pcs-handle node not available\n"); > + of_node_put(node); > return -ENODEV; > } > > -- > 2.27.0 >
Powered by blists - more mailing lists