netdev - Re: [PATCH bpf-next] bpf: return -EOPNOTSUPP when attaching to non-kernel BTF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKxePN0wf0mTHfMXPPCBV3QArOyW_6FkHQEXctKnniGmg@mail.gmail.com>
Date:   Mon, 7 Dec 2020 08:00:48 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Andrii Nakryiko <andrii@...nel.org>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH bpf-next] bpf: return -EOPNOTSUPP when attaching to
 non-kernel BTF

On Mon, Dec 7, 2020 at 6:07 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> Alexei Starovoitov <alexei.starovoitov@...il.com> writes:
>
> > On Fri, Dec 4, 2020 at 7:11 PM Andrii Nakryiko <andrii@...nel.org> wrote:
> >> +                               return -EOPNOTSUPP;
> >
> > $ cd kernel/bpf
> > $ git grep ENOTSUPP|wc -l
> > 46
> > $ git grep EOPNOTSUPP|wc -l
> > 11
>
> But also
>
> $ cd kernel/include/uapi
> $ git grep ENOTSUPP | wc -l
> 0
> $ git grep EOPNOTSUPP | wc -l
> 8
>
> (i.e., ENOTSUPP is not defined in userspace headers at all)

that's irrelevant. The kernel returns it already. It's a known constant
regardless of .h